-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add Nilstrieb to mailmap #109834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nilstrieb to mailmap #109834
Conversation
I saw that I'm on https://thanks.rust-lang.org/ twice (once as `Nilstrieb` and once as `nils`). This is because I've contributed as both `Nilstrieb` (locally) and `nils` (on github). So I've mailmapped them both to `Nilstrieb` (the less ambiguous of the two).
(rustbot has picked a reviewer for you, use r? to override) |
Not sure either, but generally seems fine. @bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (63fdb82): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
Ugh, these perf changes are clearly noise. @rustbot label: +perf-regression-triaged |
I saw that I'm on https://thanks.rust-lang.org/ twice (once as
Nilstrieb
and once asnils
).This is because I've contributed as both
Nilstrieb
(locally) andnils
(on github). So I've mailmapped them both toNilstrieb
(the less ambiguous of the two).I am not entirely sure whether I've done this correctly.