Skip to content

Rollup of 4 pull requests #109852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 2, 2023
Merged

Rollup of 4 pull requests #109852

merged 10 commits into from
Apr 2, 2023

Conversation

Noratrieb
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

sartak and others added 10 commits April 1, 2023 13:01
@sartak
Improve grammar of Iterator.partition_in_place
ec71feb 
b9535c0 Auto merge of rust-lang#109801 - aliemjay:test-implied-normalization, r=petrochenkov
@taiki-e
Fix typo in std/src/os/fd/owned.rs
455a960
@matthiaskrgr
a couple clippy::complexity fixes
8ef3bf2 
map_identity
filter_next
option_as_ref_deref
unnecessary_find_map
redundant_slicing
unnecessary_unwrap
bool_comparison
derivable_impls
manual_flatten
needless_borrowed_reference
@matthiaskrgr
fix clippy::iter_kv_map
ac229c2
@matthiaskrgr
use and_then/flat_map for map().flatten()
5a07e33
@matthiaskrgr
slighty simplify a few boolean expressions (clippy::nonminimal_bool)
73bd953
@Noratrieb
Rollup merge of rust-lang#109839 - sartak:iter-grammar, r=scottmcm
a38bdd4 
Improve grammar of Iterator.partition_in_place

This is my first PR against Rust, please let me know if there's anything I should be providing here! I didn't find any instructions specific to documentation grammar in the [std-dev guide](https://std-dev-guide.rust-lang.org/documentation/summary.html).
@Noratrieb
Rollup merge of rust-lang#109840 - taiki-e:typo, r=ChrisDenton
099f346 
Fix typo in std/src/os/fd/owned.rs
@Noratrieb
Rollup merge of rust-lang#109844 - matthiaskrgr:clippy2023_04, r=Nils…
e2ffe15 
…trieb

a couple clippy::complexity fixes

map_identity
filter_next
option_as_ref_deref
unnecessary_find_map
redundant_slicing
unnecessary_unwrap
bool_comparison
derivable_impls
manual_flatten
needless_borrowed_reference
@Noratrieb
Rollup merge of rust-lang#109846 - matthiaskrgr:clippy2023_04_III, r=…
59f394b 
…Nilstrieb

more clippy::complexity fixes (iter_kv_map, map_flatten, nonminimal_bool)
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Apr 2, 2023
@Noratrieb
Copy link
Member Author

@bors r+ rollup=never p=4

@bors
Copy link
Collaborator

bors commented Apr 2, 2023

📌 Commit 59f394b has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2023
@bors
Copy link
Collaborator

bors commented Apr 2, 2023

⌛ Testing commit 59f394b with merge 11cd4ff...

@bors
Copy link
Collaborator

bors commented Apr 2, 2023

☀️ Test successful - checks-actions
Approved by: Nilstrieb
Pushing 11cd4ff to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 2, 2023
@bors bors merged commit 11cd4ff into rust-lang:master Apr 2, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 2, 2023
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Perf Build Sha
#109846 9b42503bb0325e37472e00989c665d50572b3672
#109844 0fa5b300a58e6adede757ecb944ef4845ce41b79
#109840 d6577d84bda957005e70fa1a91f2ca1f5d36591e
#109839 cc0b51697b61976c71c403df59121ac21b62e3d9

previous master: 637d7fdb23

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@bors bors mentioned this pull request Apr 2, 2023
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (11cd4ff): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.2% [2.2%, 2.2%] 1
Regressions ❌
(secondary)		 2.4% [2.4%, 2.4%] 1
Improvements ✅
(primary)		 -0.5% [-0.5%, -0.5%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.8% [-0.5%, 2.2%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.9% [-0.9%, -0.9%] 1
All ❌✅ (primary) - - 0

@Noratrieb Noratrieb deleted the rollup-g3mgxxw branch April 2, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Noratrieb @bors @rust-timer @rustbot @sartak @taiki-e @matthiaskrgr