Fix #10755 - ICE: --linker=
#10997
Merged
Fix #10755 - ICE: --linker=
#10997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should definitely have a test as well. I think that |
|
The compile-flags system is pretty cool! 😃 I have uploaded a new patch with a test. Note: I removed the "ar"/archiver-specific changes because I could not find a way to trigger the "could not exec the archiver" error. |
| @@ -310,7 +314,9 @@ pub mod write { | |||
| assembly.as_str().unwrap().to_owned()]; | |||
|
|
|||
| debug!("{} '{}'", cc, args.connect("' '")); | |||
| match run::process_output(cc, args) { | |||
| let opt_prog = io_error::cond.trap(|_| { /*empty*/ }) | |||
| .inside(|| -> Option<ProcessOutput> run::process_output(cc, args)); | |||
There was a problem hiding this comment.
Huh, I was unaware that this was even possible to name the return type! This would all look nicer as:
let opt_prog = {
let _g = io::ignore_io_error();
run::process_output(cc, args)
};
Trap the io_error condition so that a more informative error message is displayed when the linker program cannot be started, such as when the name of the linker binary is accidentally mistyped. closes rust-lang#10755
bors
added a commit
that referenced
this pull request
Dec 22, 2013
…ing-linker, r=alexcrichton Trap the io_error condition so that a more informative error message is displayed when the linker program cannot be started, such as when the name of the linker binary is accidentally mistyped. closes #10755
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 4, 2024
…ednet new lint `legacy_numeric_constants` Rework of rust-lang#10997 - uses diagnostic items - does not lint imports of the float modules (`use std::f32`) - does not lint usage of float constants that look like `f32::MIN` I chose to make the float changes because the following pattern is actually pretty useful ```rust use std::f32; let omega = freq * 2 * f32::consts::PI; ``` and the float modules are not TBD-deprecated like the integer modules. Closes rust-lang#10995 --- changelog: New lint [`legacy_numeric_constants`] [rust-lang#12312](rust-lang/rust-clippy#12312)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trap the io_error condition so that a more informative error message is
displayed when the linker program cannot be started, such as when the
name of the linker binary is accidentally mistyped.
closes #10755