-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Increase instances of try_get_cached
#110057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I really have trouble understanding the point, besides micro optimization. Still, deserves measurement for our sanity |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit 327563f with merge b8bc2d1727981f4de16e53ba3bbc9a4bc74014cf... |
☀️ Try build successful - checks-actions |
1 similar comment
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (b8bc2d1727981f4de16e53ba3bbc9a4bc74014cf): comparison URL. Overall result: ❌ regressions - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
This increases the instances of
try_get_cached
in order to try to reduce the regressions in #109333. Using#[inline(always)]
seems to be too aggressive so this is a way to keep inlining behavior more similar to the previous state.r? @cjgillot