Skip to content

Custom MIR: Support BinOp::Offset #110190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2023
Merged

Custom MIR: Support BinOp::Offset #110190

merged 1 commit into from
Apr 12, 2023

Conversation

cbeuw
Copy link
Contributor

@cbeuw cbeuw commented Apr 11, 2023

Since offset doesn't have an infix operator, a new function Offset is added which is lowered to Rvalue::BinaryOp(BinOp::Offset, ..)

r? @oli-obk or @tmiasko or @JakobDegen

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 11, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 11, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@oli-obk
Copy link
Contributor

oli-obk commented Apr 11, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 11, 2023

📌 Commit cecb901 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2023
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Apr 11, 2023
@compiler-errors
Rollup merge of rust-lang#110190 - cbeuw:mir-offset, r=oli-obk
5eb6805 
Custom MIR: Support `BinOp::Offset`

Since offset doesn't have an infix operator, a new function `Offset` is added which is lowered to `Rvalue::BinaryOp(BinOp::Offset, ..)`

r? `@oli-obk` or `@tmiasko` or `@JakobDegen`
@compiler-errors compiler-errors mentioned this pull request Apr 11, 2023
Closed
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Apr 12, 2023
@compiler-errors
Rollup merge of rust-lang#110190 - cbeuw:mir-offset, r=oli-obk
3427cec 
Custom MIR: Support `BinOp::Offset`

Since offset doesn't have an infix operator, a new function `Offset` is added which is lowered to `Rvalue::BinaryOp(BinOp::Offset, ..)`

r? ``@oli-obk`` or ``@tmiasko`` or ``@JakobDegen``
@compiler-errors compiler-errors mentioned this pull request Apr 12, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 12, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 12, 2023
@bors
Auto merge of rust-lang#110239 - matthiaskrgr:rollup-o90hx4s, r=matth…
59a05ad 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#109959 (Fix transmute intrinsic mir validation ICE)
 - rust-lang#110176 (Renumbering cleanups)
 - rust-lang#110182 (Use `itertools::Either` instead of own impl)
 - rust-lang#110188 (Remove orphaned remove_dir_all implementation from rust-installer)
 - rust-lang#110190 (Custom MIR: Support `BinOp::Offset`)
 - rust-lang#110209 (Add regression test for rust-lang#59003)
 - rust-lang#110210 (`DescriptionCtx` cleanups)
 - rust-lang#110217 (doc: loongarch: Fix typos)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bb037e6 into rust-lang:master Apr 12, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 12, 2023
@cbeuw cbeuw deleted the mir-offset branch April 12, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.
4 participants
@cbeuw @rustbot @oli-obk @bors