Skip to content

Fix rust-gdb on FreeBSD #110335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2023
Merged

Fix rust-gdb on FreeBSD #110335

merged 2 commits into from
Apr 15, 2023

Conversation

asomers
Copy link
Contributor

@asomers asomers commented Apr 14, 2023

"\w" is a GNU-specific extension to sed. Avoid it.

Fixes #110334
Signed-off-by: Alan Somers [email protected]

@rustbot
Copy link
Collaborator

rustbot commented Apr 14, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 14, 2023
@jyn514
Copy link
Member

jyn514 commented Apr 14, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 14, 2023

📌 Commit 7e4aa11d07beee987534464ce5558cf48b2c314e has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2023
@cuviper
Copy link
Member

cuviper commented Apr 14, 2023

rust-gdbgui has the same regex.

"\w" is a GNU-specific extension to sed.  Avoid it.

Fixes rust-lang#110334
Signed-off-by: Alan Somers <[email protected]>
@asomers
Copy link
Contributor Author

asomers commented Apr 15, 2023

Good catch. I force-pushed to fix it on rust-gdbgui too.

@jyn514
Copy link
Member

jyn514 commented Apr 15, 2023

@bors r- r+

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 15, 2023
@bors
Copy link
Collaborator

bors commented Apr 15, 2023

📌 Commit 2f45d19 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 15, 2023
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 15, 2023
@cuviper
Copy link
Member

cuviper commented Apr 15, 2023

@bors r=jyn514

@bors
Copy link
Collaborator

bors commented Apr 15, 2023

📌 Commit c6b1f31 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 15, 2023
@bors
Copy link
Collaborator

bors commented Apr 15, 2023

⌛ Testing commit c6b1f31 with merge 825c706...

@bors
Copy link
Collaborator

bors commented Apr 15, 2023

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing 825c706 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 15, 2023
@bors bors merged commit 825c706 into rust-lang:master Apr 15, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 15, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (825c706): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
5.5% [5.5%, 5.5%] 1
Improvements ✅
(primary)
-3.3% [-3.3%, -3.3%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -3.3% [-3.3%, -3.3%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.2% [-2.2%, -2.2%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.2% [-2.2%, -2.2%] 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rust-gdb crashes on FreeBSD due to invalid sed syntax
8 participants