Skip to content

Remove tidy key in PR CI #111224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2023
Merged

Remove tidy key in PR CI #111224

merged 1 commit into from
May 7, 2023

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented May 4, 2023

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 4, 2023
@jyn514 jyn514 force-pushed the default-tidy branch 4 times, most recently from 96421e9 to 33400e0 Compare May 4, 2023 23:15
@jyn514 jyn514 changed the title [wip] Set tidy: false by default in PR CI Remove tidy key in PR CI May 4, 2023
This avoids confusing error messages when adding an `auto` job to CI (as
recommended in the dev-guide: https://rustc-dev-guide.rust-lang.org/tests/ci.html#using-ci-to-test).
@jyn514
Copy link
Member Author

jyn514 commented May 4, 2023

r? infra-ci

@jyn514
Copy link
Member Author

jyn514 commented May 4, 2023

cc @pietroalbini

@pietroalbini
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented May 6, 2023

📌 Commit 453c632 has been approved by pietroalbini

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2023
@bors
Copy link
Collaborator

bors commented May 7, 2023

⌛ Testing commit 453c632 with merge c4190f2...

@bors
Copy link
Collaborator

bors commented May 7, 2023

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing c4190f2 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 7, 2023
@bors bors merged commit c4190f2 into rust-lang:master May 7, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 7, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c4190f2): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
4.7% [4.1%, 5.4%] 3
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 4.7% [4.1%, 5.4%] 3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.1% [2.1%, 2.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 654.562s -> 653.436s (-0.17%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants