Implement rational() function for floats #11125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -107,6 +107,27 @@ impl<T: Clone + Integer + Ord> | |||
| } | |||
| } | |||
|
|
|||
| impl Ratio<BigInt> { | |||
| /// Converts a float into a rational number | |||
| pub fn rational<T: Float>(f: T) -> Option<BigRational> { | |||
|
Could you squash the commits? (r=me when done, make sure to comment here when you've done it, because we don't get automatic notifications when a PR is updated. :) ) |
The Ratio::from_float() converts a float (f32 and f64) into a Ratio<BigInt>. Closes rust-lang#9838
bors
added a commit
that referenced
this pull request
Dec 30, 2013
The Ratio::rational() converts a float (f32 and f64) into a Ratio<BigInt>. Closes #9838
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ratio::rational() converts a float (f32 and f64) into a
Ratio.
Closes #9838