Skip to content

Avoid compiler error about glob imports in getopts example #11142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 31, 2013
Merged

Avoid compiler error about glob imports in getopts example #11142

merged 3 commits into from
Dec 31, 2013

Conversation

alan-andrade
Copy link
Contributor

Ran into this in practice, fixing it to improve example correctness.

@alexcrichton
Copy link
Member

Hm, this makes me realize that we should probably deny all features by default in code examples. Could you remove the features added in src/librustdoc/test.rs? Code examples at least in libstd should not show off gated features by default (they should have to opt-into it if possible)

@alan-andrade
Copy link
Contributor Author

Not sure If this is what you asked for. Let me know to improve it.

@alexcrichton
Copy link
Member

Ah yes, that's what I was referencing, but are you sure that it passes make check?

@alan-andrade
Copy link
Contributor Author

I'm pretty sure . I compiled rust all over. We could double check with the bot.

Sent from my iPhone

On Dec 25, 2013, at 11:58 PM, Alex Crichton [email protected] wrote:

Ah yes, that's what I was referencing, but are you sure that it passes make check?

—
Reply to this email directly or view it on GitHub.

@alan-andrade
Copy link
Contributor Author

I tried to find the failing test with no success. I have no idea how to read the logs. Can you give me some pointers ?

@sfackler
Copy link
Member

@alanandrade At the bottom of http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/2305/steps/test/logs/stdio

The module docs for std::str use @str without a #[feature(managed_boxes)].

@alan-andrade
Copy link
Contributor Author

Special thanks to @sfackler and @huonw for the huge help and incredible patience. 👏 :D

bors added a commit that referenced this pull request Dec 31, 2013
@bors
auto merge of #11142 : alan-andrade/rust/improve_opts_example, r=cmr
d459e80 
Ran into this in practice, fixing it to improve example correctness.
@bors bors closed this Dec 31, 2013
@bors bors merged commit ff801d6 into rust-lang:master Dec 31, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jul 14, 2023
@bors
Auto merge of rust-lang#11148 - smoelius:nb-known-problems, r=Jarcho
b10a0aa 
Add "Known problems" section to `needless_borrow` documentation

While this PR doesn't fix the issue in rust-lang#11142, it at least communicates that this is a known limitation.

r? `@Jarcho`

changelog: Add "Known problems" section to `needless_borrow` documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alan-andrade @alexcrichton @sfackler @emberian @bors