Skip to content

Update links to Rust Reference in diagnostic #112498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 11, 2023
Merged

Update links to Rust Reference in diagnostic #112498

merged 2 commits into from
Jun 11, 2023

Conversation

SamZhang3
Copy link
Contributor

Instead of linking to the old Rust Reference site, which is severely outdated (Rust 1.17), link to the current website in diagnostic about incorrect literals.

@SamZhang3
Update links to Rust Reference page on literals in diagnostic
e5fccf9 
Instead of linking to the old Rust Reference site on static.rust-lang.org,
link to the current website doc.rust-lang.org/stable/reference instead in
diagnostic about incorrect literals.
@rustbot
Copy link
Collaborator

rustbot commented Jun 10, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @TaKO8Ki (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 10, 2023
Noratrieb
Noratrieb approved these changes Jun 10, 2023
View reviewed changes
Copy link
Member

@Noratrieb Noratrieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Have you searched for other occurrences of these outdated docs? There could be more than just this one. Feel free to send another PR if you find more.
r? Nilstrieb
@bors r+ rollup

@rustbot rustbot assigned Noratrieb and unassigned TaKO8Ki Jun 10, 2023
@Noratrieb
Copy link
Member

bors :(
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 10, 2023

📌 Commit e5fccf9 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2023
@SamZhang3
Copy link
Contributor Author

Awesome! Have you searched for other occurrences of these outdated docs? There could be more than just this one. Feel free to send another PR if you find more. r? Nilstrieb @bors r+ rollup

I grepped for static.rust-lang.org and this was the only instance of linking to outdated documentation on that site. Thanks for the reminder though!

@SamZhang3
Copy link
Contributor Author

@Nilstrieb Oops -- I just realized that this link more closely corresponds to the intention of the original link, and also has more complete and relevant information.

I just pushed another commit. Apologies if I'm doing anything wrong, this is my first time contributing to Rust.

@SamZhang3 SamZhang3 requested a review from Noratrieb June 10, 2023 18:53
@Noratrieb
Copy link
Member

That's fine, I'll reapprove the new commit.
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 10, 2023

📌 Commit 6336da9 has been approved by Nilstrieb

It is now in the queue for this repository.

@matthiaskrgr matthiaskrgr mentioned this pull request Jun 10, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 11, 2023
@bors
Auto merge of rust-lang#112512 - matthiaskrgr:rollup-o2jh1jx, r=matth…
970058e 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#112475 (Fix issue for module name when surround the struct literal with parentheses)
 - rust-lang#112477 (Give more helpful progress messages in `Assemble`)
 - rust-lang#112484 (Fix ntdll linkage issues on Windows UWP platforms)
 - rust-lang#112492 (Migrate GUI colors test to original CSS color format)
 - rust-lang#112493 (iat selection: normalize self ty & completely erase bound vars)
 - rust-lang#112497 (abs_sub: fix typo 0[-:][+.]0)
 - rust-lang#112498 (Update links to Rust Reference in diagnostic)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 46b64aa into rust-lang:master Jun 11, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noratrieb Noratrieb Awaiting requested review from Noratrieb

Assignees

@Noratrieb Noratrieb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.
5 participants
@SamZhang3 @rustbot @Noratrieb @bors @TaKO8Ki