⬆️ rust-analyzer #112784
Merged
⬆️ rust-analyzer #112784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workflow is currently failing because it's trying to publish 0.0.16, while the last version published was 0.0.149.
… assists transform lifetimes
`replace_derive_with_manual_impl` was slightly since it used `add_trait_assoc_items_to_impl` (which was also used by `add_missing_impl_members`)
internal: Sync from rust
fix: Fix ci never running on nightly when proc-macro things change Was wondering why this wasn't running on the subtree sync ...
…c-str, r=HKalbasi
feat: inline const as literal
Assist: inline_const_as_literal
Evaluate and inline const variable as literal.
```rust
const STRING: &str = "Hello, World!";
fn something() -> &'static str {
STR$0ING
}
```
->
```rust
const STRING: &str = "Hello, World!";
fn something() -> &'static str {
"Hello, World!"
}
```
fix: Fix proc-macro slow test
…oc, r=HKalbasi
fix: only generate trait bound for associated types in field types
Given the following definitions:
```rust
trait Trait {
type A;
type B;
type C;
}
#[derive(Clone)]
struct S<T: Trait>
where
T::A: Send,
{
qualified: <T as Trait>::B,
shorthand: T::C,
}
```
we currently expand the derive macro to:
```rust
impl<T> Clone for S<T>
where
T: Trait + Clone,
T::A: Clone,
T::B: Clone,
T::C: Clone,
{ /* ... */ }
```
This does not match how rustc expands it. Specifically, `Clone` bounds for `T::A` and `T::B` should not be generated.
The criteria for associated types to get bound seem to be 1) the associated type appears as part of field types AND 2) it's written in the shorthand form. I have no idea why rustc doesn't consider qualified associated types (there's even a comment that suggests they should be considered; see rust-lang#50730), but it's important to follow rustc.
…nicola Fix typo in reload.rs Thanks for the amazing LSP! I found a small typo and fixed it.
Fix unwrap on None in expanding format args fix rust-lang#15002
internal: Fix dependency warning Hope this doesn't break rust-lang#14984 again.
rust-analyzer supports both `sysroot` and `sysroot_src` in `rust-project.json`. Document `sysroot` and show example values for both fields.
internal: Do not allocate unnecessarily when importing macros from parent modules
internal: Add more context to overly long loop turn message
internal: Analyze all bodies in analysis-stats, not just functions
analysis-stats: Add body lowering step, track time of each step separtely
…do-not-transform-const-params, r=lowr fix: implement missing members doesn't transform const params and default types Fixes rust-lang/rust-analyzer#13363
fix: Add binding definition for for-expr iterator desugared binding
internal: Shrink size of hir::Binding
rustbot
added
the
S-waiting-on-review
|
Some changes occurred in src/tools/rust-analyzer cc @rust-lang/rust-analyzer |
|
@bors r+ p=1 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (3c9e070): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 653.833s -> 657.557s (0.57%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ghost