Skip to content

Migrate GUI colors test to original CSS color format #112996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 30 additions & 30 deletions tests/rustdoc-gui/settings.goml
Original file line number Diff line number Diff line change
Expand Up @@ -56,27 +56,27 @@ move-cursor-to: "#settings-menu > a"
assert-css: (
"#theme-dark",
{
"border-color": "rgb(153, 153, 153)",
"box-shadow": "rgb(53, 53, 53) 0px 0px 0px 3px inset",
"border-color": "#999",
"box-shadow": "#353535 0px 0px 0px 3px inset",
"border-width": "2px",
},
)
assert-css: ("#theme-light", {"border-color": "rgb(153, 153, 153)", "box-shadow": "none"})
assert-css: ("#theme-light", {"border-color": "#999", "box-shadow": "none"})
// Let's start with the hover for radio buttons.
move-cursor-to: "#theme-dark"
assert-css: (
"#theme-dark",
{
"border-color": "rgb(33, 150, 243)",
"box-shadow": "rgb(53, 53, 53) 0px 0px 0px 3px inset",
"border-color": "#2196f3",
"box-shadow": "#353535 0px 0px 0px 3px inset",
"border-width": "2px",
},
)
move-cursor-to: "#theme-light"
assert-css: (
"#theme-light",
{
"border-color": "rgb(33, 150, 243)",
"border-color": "#2196f3",
"box-shadow": "none",
"border-width": "2px",
}
Expand All @@ -87,17 +87,17 @@ focus: "#theme-dark"
assert-css: (
"#theme-dark",
{
"border-color": "rgb(153, 153, 153)",
"box-shadow": "rgb(53, 53, 53) 0px 0px 0px 3px inset, rgb(33, 150, 243) 0px 0px 2px 2px",
"border-color": "#999",
"box-shadow": "#353535 0px 0px 0px 3px inset, #2196f3 0px 0px 2px 2px",
"border-width": "2px",
},
)
focus: "#theme-light"
assert-css: (
"#theme-light",
{
"border-color": "rgb(153, 153, 153)",
"box-shadow": "rgb(33, 150, 243) 0px 0px 1px 1px",
"border-color": "#999",
"box-shadow": "#2196f3 0px 0px 1px 1px",
"border-width": "2px",
},
)
Expand All @@ -107,8 +107,8 @@ focus: "#theme-dark"
assert-css: (
"#theme-dark",
{
"border-color": "rgb(33, 150, 243)",
"box-shadow": "rgb(53, 53, 53) 0px 0px 0px 3px inset, rgb(33, 150, 243) 0px 0px 2px 2px",
"border-color": "#2196f3",
"box-shadow": "#353535 0px 0px 0px 3px inset, #2196f3 0px 0px 2px 2px",
"border-width": "2px",
},
)
Expand All @@ -117,8 +117,8 @@ focus: "#theme-light"
assert-css: (
"#theme-light",
{
"border-color": "rgb(33, 150, 243)",
"box-shadow": "rgb(33, 150, 243) 0px 0px 1px 1px",
"border-color": "#2196f3",
"box-shadow": "#2196f3 0px 0px 1px 1px",
"border-width": "2px",
},
)
Expand Down Expand Up @@ -154,8 +154,8 @@ compare-elements-position-near: (
assert-css: (
"#auto-hide-large-items",
{
"background-color": "rgb(33, 150, 243)",
"border-color": "rgb(153, 153, 153)",
"background-color": "#2196f3",
"border-color": "#999",
// 1px border when checked
"border-width": "1px",
},
Expand All @@ -164,7 +164,7 @@ assert-css: (
"#auto-hide-method-docs",
{
"background-color": "rgba(0, 0, 0, 0)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not something we set in our CSS. This test is to ensure that, so I didn't change the color format for these.

"border-color": "rgb(153, 153, 153)",
"border-color": "#999",
// 2px border when unchecked
"border-width": "2px",
},
Expand All @@ -174,8 +174,8 @@ move-cursor-to: "#auto-hide-large-items"
assert-css: (
"#auto-hide-large-items",
{
"background-color": "rgb(33, 150, 243)",
"border-color": "rgb(33, 150, 243)",
"background-color": "#2196f3",
"border-color": "#2196f3",
// 1px border when checked
"border-width": "1px",
},
Expand All @@ -185,7 +185,7 @@ assert-css: (
"#auto-hide-method-docs",
{
"background-color": "rgba(0, 0, 0, 0)",
"border-color": "rgb(33, 150, 243)",
"border-color": "#2196f3",
// 2px border when unchecked
"border-width": "2px",
},
Expand All @@ -196,9 +196,9 @@ focus: "#auto-hide-large-items"
assert-css: (
"#auto-hide-large-items",
{
"background-color": "rgb(33, 150, 243)",
"border-color": "rgb(153, 153, 153)",
"box-shadow": "rgb(33, 150, 243) 0px 0px 1px 1px",
"background-color": "#2196f3",
"border-color": "#999",
"box-shadow": "#2196f3 0px 0px 1px 1px",
// 1px border when checked
"border-width": "1px",
},
Expand All @@ -208,8 +208,8 @@ assert-css: (
"#auto-hide-method-docs",
{
"background-color": "rgba(0, 0, 0, 0)",
"border-color": "rgb(153, 153, 153)",
"box-shadow": "rgb(33, 150, 243) 0px 0px 1px 1px",
"border-color": "#999",
"box-shadow": "#2196f3 0px 0px 1px 1px",
// 2px border when unchecked
"border-width": "2px",
},
Expand All @@ -220,9 +220,9 @@ focus: "#auto-hide-large-items"
assert-css: (
"#auto-hide-large-items",
{
"background-color": "rgb(33, 150, 243)",
"border-color": "rgb(33, 150, 243)",
"box-shadow": "rgb(33, 150, 243) 0px 0px 1px 1px",
"background-color": "#2196f3",
"border-color": "#2196f3",
"box-shadow": "#2196f3 0px 0px 1px 1px",
// 1px border when checked
"border-width": "1px",
},
Expand All @@ -233,8 +233,8 @@ assert-css: (
"#auto-hide-method-docs",
{
"background-color": "rgba(0, 0, 0, 0)",
"border-color": "rgb(33, 150, 243)",
"box-shadow": "rgb(33, 150, 243) 0px 0px 1px 1px",
"border-color": "#2196f3",
"box-shadow": "#2196f3 0px 0px 1px 1px",
// 2px border when unchecked
"border-width": "2px",
},
Expand Down