Skip to content

Remove re-exports of std::io::stdio::{print, println} in the prelude. #11416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2014

Conversation

brendanzab
Copy link
Member

The print! and println! macros are now the preferred method of printing, and so there is no reason to export the stdio functions in the prelude. The functions have also been replaced by their macro counterparts in the tutorial and other documentation so that newcomers don't get confused about what they should be using.

@alexcrichton
Copy link
Member

This seems very desirable to me! This should probably be discussed a little bit though to make sure this is ok.

I am very much in favor of this.

@brendanzab
Copy link
Member Author

Rebased.

@alexcrichton
Copy link
Member

r=me with a rebase

@brendanzab
Copy link
Member Author

@alexcrichton rebased

bors added a commit that referenced this pull request Jan 10, 2014
The `print!` and `println!` macros are now the preferred method of printing, and so there is no reason to export the `stdio` functions in the prelude. The functions have also been replaced by their macro counterparts in the tutorial and other documentation so that newcomers don't get confused about what they should be using.
@brendanzab
Copy link
Member Author

Ok, rebased - hopefully this fixed the debug-info tests.

adrientetar added a commit to adrientetar/rust-tuts that referenced this pull request Jan 10, 2014
@brendanzab
Copy link
Member Author

Fixed a merge issue caused by a use of println in 6f875c9 and rebased. r?

The `print!` and `println!` macros are now the preferred method of printing, and so there is no reason to export the `stdio` functions in the prelude. The functions have also been replaced by their macro counterparts in the tutorial and other documentation so that newcomers don't get confused about what they should be using.
bors added a commit that referenced this pull request Jan 11, 2014
The `print!` and `println!` macros are now the preferred method of printing, and so there is no reason to export the `stdio` functions in the prelude. The functions have also been replaced by their macro counterparts in the tutorial and other documentation so that newcomers don't get confused about what they should be using.
@bors bors closed this Jan 11, 2014
@bors bors merged commit 4fc0452 into rust-lang:master Jan 11, 2014
@brendanzab brendanzab deleted the remove-print-fns branch January 11, 2014 05:44
chris-morgan added a commit to chris-morgan/rust-http that referenced this pull request Jan 13, 2014
(I’m getting good at concise commit messages, aren’t I?)
flip1995 pushed a commit to flip1995/rust that referenced this pull request Sep 7, 2023
…rednet

Use multipart suggestions for raw string lints

Should make it slightly easier to see the suggested edit

Before/after for `needless_raw_string_hashes`:

| Before| After |
|--------|--------|
| ![before](https://github.com/rust-lang/rust-clippy/assets/1830331/da52a436-d890-4594-9191-819c1af946c7) | ![after](https://github.com/rust-lang/rust-clippy/assets/1830331/9731d790-8efa-42a2-b2e9-0ec51398f8f3) |

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants