-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Remove re-exports of std::io::stdio::{print, println} in the prelude. #11416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems very desirable to me! This should probably be discussed a little bit though to make sure this is ok. I am very much in favor of this. |
Rebased. |
r=me with a rebase |
@alexcrichton rebased |
bors
added a commit
that referenced
this pull request
Jan 10, 2014
The `print!` and `println!` macros are now the preferred method of printing, and so there is no reason to export the `stdio` functions in the prelude. The functions have also been replaced by their macro counterparts in the tutorial and other documentation so that newcomers don't get confused about what they should be using.
Ok, rebased - hopefully this fixed the debug-info tests. |
adrientetar
added a commit
to adrientetar/rust-tuts
that referenced
this pull request
Jan 10, 2014
Fixed a merge issue caused by a use of |
The `print!` and `println!` macros are now the preferred method of printing, and so there is no reason to export the `stdio` functions in the prelude. The functions have also been replaced by their macro counterparts in the tutorial and other documentation so that newcomers don't get confused about what they should be using.
bors
added a commit
that referenced
this pull request
Jan 11, 2014
The `print!` and `println!` macros are now the preferred method of printing, and so there is no reason to export the `stdio` functions in the prelude. The functions have also been replaced by their macro counterparts in the tutorial and other documentation so that newcomers don't get confused about what they should be using.
chris-morgan
added a commit
to chris-morgan/rust-http
that referenced
this pull request
Jan 13, 2014
(I’m getting good at concise commit messages, aren’t I?)
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Sep 7, 2023
…rednet Use multipart suggestions for raw string lints Should make it slightly easier to see the suggested edit Before/after for `needless_raw_string_hashes`: | Before| After | |--------|--------| |  |  | changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
print!
andprintln!
macros are now the preferred method of printing, and so there is no reason to export thestdio
functions in the prelude. The functions have also been replaced by their macro counterparts in the tutorial and other documentation so that newcomers don't get confused about what they should be using.