-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Optimize Take::{fold, for_each} when wrapping TrustedRandomAccess iterators #115273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @cuviper (rustbot has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit 72b01d5 with merge 7d5ad749fca60517ea8bcc653127f44338571f25... |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (7d5ad749fca60517ea8bcc653127f44338571f25): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 631.583s -> 630.336s (-0.20%) |
@bors r+ |
⌛ Testing commit 07a1d5f with merge 81100a59d1bb866db62914253fb38b46d01880d3... |
💔 Test failed - checks-actions |
This comment has been minimized.
This comment has been minimized.
seems like a transient issue @bors retry |
⌛ Testing commit 07a1d5f with merge 08403c4888652a3e67c2e0d921181cbe93dae630... |
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
limited the test to x86-64 since vectorization differs between platforms @bors r=cuviper |
☀️ Test successful - checks-actions |
Finished benchmarking commit (c4f2577): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 629.877s -> 629.451s (-0.07%) |
No description provided.