Skip to content

add stable provenance #115470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2023
Merged

add stable provenance #115470

merged 1 commit into from
Sep 3, 2023

Conversation

ericmarkmartin
Copy link
Contributor

@ericmarkmartin ericmarkmartin commented Sep 2, 2023 •
edited
Loading

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 2, 2023
@rustbot
Copy link
Collaborator

rustbot commented Sep 2, 2023

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino

@oli-obk
Copy link
Contributor

oli-obk commented Sep 3, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 3, 2023

📌 Commit cb7d020 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Sep 3, 2023

@bors rollup

@bors
Copy link
Collaborator

bors commented Sep 3, 2023

⌛ Testing commit cb7d020 with merge 7cc5ac2...

@bors
Copy link
Collaborator

bors commented Sep 3, 2023

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 7cc5ac2 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 3, 2023
@bors bors merged commit 7cc5ac2 into rust-lang:master Sep 3, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 3, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7cc5ac2): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.2% [2.2%, 2.2%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 628.29s -> 630.112s (0.29%)
Artifact size: 316.65 MiB -> 316.75 MiB (0.03%)

@ericmarkmartin ericmarkmartin deleted the stable-prov branch September 4, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spastorino spastorino

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ericmarkmartin @rustbot @oli-obk @bors @rust-timer @spastorino