-
Notifications
You must be signed in to change notification settings - Fork 13.3k
make link_llvm_intrinsics and platform_intrinsics features internal #116093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
For LLVM intrinsics you wouldn't "just" ICE, you would likely segfault the compiler on incorrect usage. |
@bors r+ rollup |
☀️ Test successful - checks-actions |
Finished benchmarking commit (92009f2): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 632.103s -> 632.158s (0.01%) |
These are both a lot like
feature(intrinsics)
, just slightly different syntax, so IMO it should be treated the same (also in terms of: if you get ICEs with this feature, that's on you -- we are not doing "nice" type-checking for intrinsics).