Skip to content

[Don't merge][test] mir niche checks #116414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

dianqk
Copy link
Member

@dianqk dianqk commented Oct 4, 2023

@rustbot
Copy link
Collaborator

rustbot commented Oct 4, 2023

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 4, 2023
@rustbot
Copy link
Collaborator

rustbot commented Oct 4, 2023

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

@rust-log-analyzer

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented Oct 4, 2023

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras

The Miri subtree was changed

cc @rust-lang/miri

@rust-log-analyzer

This comment has been minimized.

@saethlin
Copy link
Member

saethlin commented Oct 4, 2023

@dianqk If you want to get CI to pass with the MIR transform in here, you probably need to add -Zmir-enable-passes=-CheckNiches or -Cdebug-assertions=no to the tests that are failing due to perturbation by the check.

@rust-log-analyzer

This comment has been minimized.

@dianqk
Copy link
Member Author

dianqk commented Oct 4, 2023

I just remembered that x86_64-gnu-llvm-15 and x86_64-gnu-tools do not use the built-in LLVM.

@rust-log-analyzer

This comment has been minimized.

@dianqk dianqk force-pushed the try-mir-niche-checks branch from 3bc40da to fdf0f70 Compare October 5, 2023 01:51
@rust-log-analyzer

This comment has been minimized.

@dianqk dianqk force-pushed the try-mir-niche-checks branch from fdf0f70 to 7c81330 Compare October 5, 2023 02:02
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Oct 5, 2023
@dianqk dianqk marked this pull request as draft October 5, 2023 02:15
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@dianqk
Copy link
Member Author

dianqk commented Oct 9, 2023

Verify completion.

@dianqk dianqk closed this Oct 9, 2023
@dianqk dianqk reopened this Oct 10, 2023
@dianqk
Copy link
Member Author

dianqk commented Oct 10, 2023

Check again due to the reimplementation of the upstream patch.

@dianqk dianqk closed this Oct 10, 2023
@dianqk dianqk deleted the try-mir-niche-checks branch March 4, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants