-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Fix unused_parens issue when cast is followed LT #117321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
282c740
to
eef4e65
Compare
@rustbot ready |
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (3071aef): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 665.459s -> 665.943s (0.07%) |
Fixes #117142
The original check only checks
a as (i32) < 0
, this fix extends it to handleb + a as (i32) < 0
.A better way is maybe we suggest
(a as i32) < 0
instead of suppressing the warning, maybe following PR could improve it.