Skip to content

Switch fuchsia-test-runner.py to ffx product #117799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 41 additions & 7 deletions src/ci/docker/scripts/fuchsia-test-runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import fcntl
import glob
import hashlib
import io
import json
import os
import platform
Expand Down Expand Up @@ -276,27 +277,60 @@ def start(self):
stderr=self.subprocess_output(),
)

# Start emulator
self.log_info("Starting emulator...")
product_bundle = "terminal.qemu-" + self.triple_to_arch(self.target)
# Look up the product bundle transfer manifest.
self.log_info("Looking up the product bundle transfer manifest...")
product_name = "minimal." + self.triple_to_arch(self.target)
fuchsia_version = "14.20230811.2.1"

# FIXME: We should be able to replace this with the machine parsable
# `ffx --machine json product lookup ...` once F15 is released.
out = subprocess.check_output(
[
ffx_path,
"product",
"lookup",
product_name,
fuchsia_version,
"--base-url",
"gs://fuchsia/development/" + fuchsia_version,
],
env=ffx_env,
stderr=self.subprocess_output(),
)

self.log_debug(out)

for line in io.BytesIO(out):
if line.startswith(b"gs://"):
transfer_manifest_url = line.rstrip()
break
else:
raise Exception("Unable to parse transfer manifest")

# Download the product bundle.
product_bundle_dir = os.path.join(self.tmp_dir(), 'product-bundle')
subprocess.check_call(
[
ffx_path,
"product-bundle",
"get",
product_bundle,
"product",
"download",
transfer_manifest_url,
product_bundle_dir,
"--force",
],
env=ffx_env,
stdout=self.subprocess_output(),
stderr=self.subprocess_output(),
)

# Start emulator
# FIXME: condition --accel hyper on target arch matching host arch
subprocess.check_call(
[
ffx_path,
"emu",
"start",
product_bundle,
product_bundle_dir,
"--headless",
"--log",
self.emulator_log_path(),
Expand Down
4 changes: 3 additions & 1 deletion src/doc/rustc/src/platform-support/fuchsia.md
Original file line number Diff line number Diff line change
Expand Up @@ -692,10 +692,12 @@ Fuchsia's test runner interacts with the Fuchsia emulator and is located at
test environment with:

```sh
src/ci/docker/scripts/fuchsia-test-runner.py start \
( \
src/ci/docker/scripts/fuchsia-test-runner.py start \
--rust-build ${RUST_SRC_PATH}/build \
--sdk ${SDK_PATH} \
--target {x86_64-unknown-fuchsia|aarch64-unknown-fuchsia} \
)
```

Where `${RUST_SRC_PATH}/build` is the `build-dir` set in `config.toml` and
Expand Down