bootstrap: please document why a config change requires migration #117809
Conversation
|
r? @onur-ozkan (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Maybe a more "enforceable" solution would be to use a struct containing a PR number and a string with config.toml modification instructions that would be printed by bootstrap? And use this struct in the array instead of just PR numbers. |
|
Maybe. @onur-ozkan said they are re-thinking parts of the system anyway. I honestly don't really want to spend time on this, I just got frustrated this morning when I got two change notifications for my config.toml and none of them told me what I should do to my config.toml in order to migrate... see discussion on Zulip. Currently this entire system is more disruptive to my rustc development than I think is appropriate. |
|
I also removed the duplicate printing of the changelog notice. This message is so verbose it gets in the way of regular rustc development (I can't see the output I am looking for in between all these warnings), and the message really is not important enough to justify that. (At least, the 3 times that this system was invoked so far, it really wasn't very important that everyone drop what they are doing and immediately change their config.) |
| /// Also make sure that your PR description tells people what they need to do | ||
| /// to migrate their configuration. (If there's nothing to migrate, consider whether | ||
| /// having *every rustc developer* open your PR page is really necessary.) |
There was a problem hiding this comment.
As #117815 aims to fix this problem, this change shouldn't be needed anymore.
Do we still need to do that? With #117815, this 2nd print becomes quite important. See #117815 (comment) |
|
This entire PR is superseded by #117815. |
onur-ozkan
removed
the
S-waiting-on-review
Currently I go to these PRs to learn how to update my config, and then I am staring at a PR description that was clearly written for the reviewer, not the random rustc developer just updating their checkout. That's no good.