Skip to content

Miri subtree update #117855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 13, 2023
Merged

Miri subtree update #117855

merged 13 commits into from
Nov 13, 2023

Conversation

RalfJung
Copy link
Member

r? @ghost

RalfJung and others added 13 commits November 10, 2023 08:30
@RalfJung
data_race: link to docs for 'unusual' race conditions
be09a10
@bors
Auto merge of rust-lang#3155 - RalfJung:data-race-docs, r=RalfJung
fe0b970 
data_race: link to docs for 'unusual' race conditions
@devnexen
freebsd interceptions update proposal
be6f27b
@RalfJung
tweak comments
887ffc6
@RalfJung
better error when calling pthread shims on unsupported unixes
ba523be
@bors
Auto merge of rust-lang#3143 - devnexen:fbsd_update, r=RalfJung
e25a04f 
freebsd interceptions update proposal
@eduardosm
Implement roundps and roundpd SSE4.1 intrinsics
7f201f8
@max-heller @RalfJung
allow allocations referenced by main thread TLS to leak
c226533
@bors
Auto merge of rust-lang#2931 - max-heller:issue-2881, r=RalfJung
eb2c643 
Treat thread-local statics on main thread as static roots for leakage analysis

Miri currently treats allocations as leaked if they're only referenced in thread-local statics. For threads other than the main thread, this is correct, since the thread can terminate before the program does, but references in the main thread's locals should be treated as living for the duration of the program since the thread lives for the duration of the program.

This PR adds thread-local statics and TLS keys as "static roots" for leakage analysis, but does not yet bless the example program from rust-lang#2881. See rust-lang/miri#2881 (comment)

Closes rust-lang#2881
@RalfJung
more consistent naming for TLS tests
10c9e75
@bors
Auto merge of rust-lang#3158 - RalfJung:tls-rename, r=RalfJung
9721690 
more consistent naming for TLS tests

"tls_static" for `#[thread_local] static`, "tls_macro" for `thread_local!`
@eduardosm
Improve SSE4.1 rounding tests coverage
d927f41 
To make sure the rounding direction is working as expected
@bors
Auto merge of rust-lang#3159 - eduardosm:sse41-round, r=RalfJung
f86fa09 
Implement round.ps and round.pd SSE4.1 intrinsics

I had forgotten them.

I also increased the coverage of rounding tests to make sure the rounding direction is working as expected (e.g. test `1.25`, `1.5`, `1.75`...).
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 12, 2023
@rustbot
Copy link
Collaborator

rustbot commented Nov 12, 2023

The Miri subtree was changed

cc @rust-lang/miri

@RalfJung
Copy link
Member Author

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 12, 2023

📌 Commit f86fa09 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2023
@bors
Copy link
Collaborator

bors commented Nov 12, 2023

⌛ Testing commit f86fa09 with merge 0828c15...

@bors
Copy link
Collaborator

bors commented Nov 13, 2023

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 0828c15 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 13, 2023
@bors bors merged commit 0828c15 into rust-lang:master Nov 13, 2023
@rustbot rustbot added this to the 1.76.0 milestone Nov 13, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0828c15): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Warning ⚠: The following benchmark(s) failed to build:

  • cargo-0.60.0

cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.6% [0.4%, 0.8%] 2
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.6% [0.4%, 0.8%] 2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -3.5% [-3.5%, -3.5%] 1
Improvements ✅
(secondary)		 -1.5% [-1.5%, -1.5%] 1
All ❌✅ (primary) -3.5% [-3.5%, -3.5%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.7% [0.7%, 0.7%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.5% [-0.5%, -0.5%] 2
Improvements ✅
(secondary)		 -2.2% [-2.3%, -2.1%] 2
All ❌✅ (primary) -0.1% [-0.5%, 0.7%] 3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 674.176s -> 673.749s (-0.06%)
Artifact size: 311.09 MiB -> 311.08 MiB (-0.00%)

@RalfJung RalfJung deleted the miri branch November 16, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.
7 participants
@RalfJung @rustbot @bors @rust-timer @devnexen @eduardosm @max-heller