Skip to content

Add /doc/{flate,rustdoc} to .gitignore #11833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2014

Conversation

lilyball
Copy link
Contributor

No description provided.

@alexcrichton
Copy link
Member

Hm, this is getting to the point where we need a different way to go about this. We're going to add lots and lots of crates soon, and I don't want to keep doing this. I think we can have an ignore file like this:

doc/*
!doc/*.md
!doc/lib

Can you see if that'd work?

@lilyball
Copy link
Contributor Author

@alexcrichton We could certainly introduce a doc pattern like that, I'm just mildly worried that this could cause problems if someone wants to introduce a different filetype into this dir, or even a subdir that's not generated by rustdoc. For example, git ls-files says that doc/po is a subdir that has tracked files in it, so that would need to be unignored as well.

@alexcrichton
Copy link
Member

I'd rather not have to keep adding lines for every crate we add to the build process, so we have the option of using patterns and just remembering to un-ignore things, or we could also generate docs into the build directory instead of the doc directory (which perhaps we should be doing anyway).

@brson
Copy link
Contributor

brson commented Jan 28, 2014

We should change the location where docs are built. This also causes us a problem with make clean.

@brson
Copy link
Contributor

brson commented Jan 28, 2014

Not that we can't do this for now.

@brson
Copy link
Contributor

brson commented Jan 28, 2014

I r+ed because I think we should do the fix in #11860 to squash this problem for good.

bors added a commit that referenced this pull request Jan 28, 2014
@bors bors closed this Jan 28, 2014
@bors bors merged commit 2846ee6 into rust-lang:master Jan 28, 2014
@lilyball lilyball deleted the gitignore-doc-flate-rustdoc branch January 28, 2014 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants