Avoid per-register closure expansions

[Mark-Simulacrum]

Best reviewed with whitespace ignored.

This hopefully reduces overall size of the binary. Probably zero impact in instructions/cycles in rustc-perf since we don't really have any asm benchmarks AFAIK...

[rustbot]

r? @spastorino

(rustbot has picked a reviewer for you, use r? to override)

[Mark-Simulacrum]

@bors try @rust-timer queue

[bors]

⌛ Trying commit adb3f2e with merge 6aaad64...

[bors]

☀️ Try build successful - checks-actions
Build commit: 6aaad64 (6aaad646f4a645c8dcb0b9968ef10523a7a5bf7a)

[spastorino]

Seems good to me r=me once your happy with perf.

[rust-timer]

Finished benchmarking commit (6aaad64): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[2.8%, 2.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	5
All ❌✅ (primary)	-	-	0

Bootstrap: 675.005s -> 675.329s (0.05%)
Artifact size: 313.35 MiB -> 313.35 MiB (0.00%)

[Mark-Simulacrum]

The relevant code went down in size by ~58 kb (74,052 -> 16,284 bytes) in the try build, which I'm happy with.

Rebased, waiting for PR CI to pass and then will approve.

[Mark-Simulacrum]

@bors r=spastorino

[bors]

📌 Commit 5980a17 has been approved by spastorino

It is now in the queue for this repository.

[bors]

⌛ Testing commit 5980a17 with merge 90e321d...

[bors]

☀️ Test successful - checks-actions
Approved by: spastorino
Pushing 90e321d to master...

[rust-timer]

Finished benchmarking commit (90e321d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.733s -> 672.65s (0.14%)
Artifact size: 313.93 MiB -> 313.95 MiB (0.01%)