-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Address unused tuple struct fields in the standard library #118383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address unused tuple struct fields in the standard library #118383
Conversation
r? @m-ou-se (rustbot has picked a reviewer for you, use r? to override) |
library/alloc/src/boxed/thin.rs
Outdated
@@ -171,7 +171,7 @@ struct WithHeader<H>(NonNull<u8>, PhantomData<H>); | |||
/// An opaque representation of `WithHeader<H>` to avoid the | |||
/// projection invariance of `<T as Pointee>::Metadata`. | |||
#[repr(transparent)] | |||
struct WithOpaqueHeader(NonNull<u8>); | |||
struct WithOpaqueHeader(#[allow(unused_tuple_struct_fields)] NonNull<u8>); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future readers of this code, it's probably helpful to add a comment explaining why this field is 'unused'.
struct WithOpaqueHeader(#[allow(unused_tuple_struct_fields)] NonNull<u8>); | |
#[allow(unused_tuple_struct_fields)] // Field only used through `WithHeader` type above. | |
struct WithOpaqueHeader(NonNull<u8>); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, tweaked!
31abe0a
to
115eac0
Compare
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#118342 (Dont suggest `!` for path in function call if it has generic args) - rust-lang#118383 (Address unused tuple struct fields in the standard library) - rust-lang#118401 (`rustc_ast_lowering` cleanups) - rust-lang#118409 (format_foreign.rs: unwrap return Option value for `fn position`, as it always returns Some) - rust-lang#118413 (Fix the issue of suggesting unwrap/expect for shorthand field) - rust-lang#118425 (Update cargo) - rust-lang#118429 (Fix a typo in a `format_args!` note) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#118383 - shepmaster:unused-tuple-struct-field-cleanup-stdlib, r=m-ou-se Address unused tuple struct fields in the standard library
No description provided.