Skip to content

-Zfuel is incompatible with incremental compilation #118442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Nov 29, 2023

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Nov 29, 2023

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 29, 2023
@lqd
Copy link
Member

lqd commented Nov 29, 2023

Are the fuel values printed by -Z print-fuel meaningful with incremental compilation turned on? (if you can't even then use -Zfuel with them)

r=me with or without the nit above about stderrs

@tmiasko
Copy link
Contributor Author

tmiasko commented Dec 8, 2023

  • Updated to also reject -Z print-fuel, since it has no practical application without -Z fuel.

@bors r=lqd

@bors
Copy link
Collaborator

bors commented Dec 8, 2023

📌 Commit 1a47e41 has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 8, 2023
@bors
Copy link
Collaborator

bors commented Dec 8, 2023

⌛ Testing commit 1a47e41 with merge d6fa38a...

@bors
Copy link
Collaborator

bors commented Dec 8, 2023

☀️ Test successful - checks-actions
Approved by: lqd
Pushing d6fa38a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 8, 2023
@bors bors merged commit d6fa38a into rust-lang:master Dec 8, 2023
@rustbot rustbot added this to the 1.76.0 milestone Dec 8, 2023
@tmiasko tmiasko deleted the fuel-inc branch December 8, 2023 03:23
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d6fa38a): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.8% [2.8%, 2.8%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.8% [2.8%, 2.8%] 1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.8% [0.5%, 3.0%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.7% [-2.9%, -0.4%] 2
Improvements ✅
(secondary)
-2.2% [-2.2%, -2.2%] 1
All ❌✅ (primary) 0.0% [-2.9%, 3.0%] 4

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.6% [2.6%, 2.6%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.6% [2.6%, 2.6%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 673.459s -> 675.561s (0.31%)
Artifact size: 314.00 MiB -> 314.00 MiB (-0.00%)

@rustbot rustbot added the perf-regression Performance regression. label Dec 8, 2023
@Mark-Simulacrum
Copy link
Member

This benchmark appears to be noisy, this change is within that noise floor:

image

Removing regression label.

@Mark-Simulacrum Mark-Simulacrum removed the perf-regression Performance regression. label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants