-
Notifications
You must be signed in to change notification settings - Fork 13.3k
bootstrap: use same make flags with rustdoc #119292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Keeping same `MAKEFLAGS` and `MFLAGS` for rustdoc should allow rustdoc to use the same jobserver. Signed-off-by: onur-ozkan <[email protected]>
(rustbot has picked a reviewer for you, use r? to override) |
@bors rollup=iffy |
@@ -1221,11 +1221,6 @@ impl<'a> Builder<'a> { | |||
cmd.arg("-Dwarnings"); | |||
} | |||
cmd.arg("-Znormalize-docs"); | |||
|
|||
// Remove make-related flags that can cause jobserver problems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a temporary fix applied 5 years ago. Let's see if still happens.
Thanks for the PR! |
☀️ Test successful - checks-actions |
Finished benchmarking commit (13ea97c): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 669.882s -> 667.944s (-0.29%) |
Keeping same
MAKEFLAGS
andMFLAGS
for rustdoc should allow rustdoc to use the same jobserver.