Skip to content

Move base64 out of extra. #11980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Move base64 out of extra. #11980

wants to merge 1 commit into from

Conversation

nham
Copy link
Contributor

@nham nham commented Feb 1, 2014

In accordance with the dissolution of libextra (#8784), this moves base64 out of libextra and into its own module.

In accordance with the dissolution of libextra (rust-lang#8784), this moves base64 out of libextra and into its own module.
@sfackler
Copy link
Member

sfackler commented Feb 1, 2014

I would think that extra::hex should move with it. Maybe others like extra::json as well?

@huonw
Copy link
Member

huonw commented Feb 1, 2014

@olsonjeffery is moving at least serialize and ebml into libserialize (not json yet, due to it requiring treemap), maybe that includes hex and json?

@olsonjeffery
Copy link
Contributor

@nham this PR should probably be closed and re-submitted w/ base64 and hex going in to libserialize. Can you do that?

Possibly also json, as @huonw mentions.. this involves libserialize taking a dep on libcontainer, where TreeMap now resides.

@liigo
Copy link
Contributor

liigo commented Feb 12, 2014

I done it. #12200 Move base64 and hex from libextra to libserialize.

@alexcrichton
Copy link
Member

Closed by #12200

flip1995 pushed a commit to flip1995/rust that referenced this pull request Jan 11, 2024
…N-tostring, r=llogiq

Extend UNCONDITIONAL_RECURSION to check for ToString implementations

Follow-up of rust-lang/rust-clippy#11938.

r? `@llogiq`

changelog: Extend `UNCONDITIONAL_RECURSION` to check for `ToString` implementations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants