Rollup of 4 pull requests #119879
Merged
Rollup of 4 pull requests #119879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SION` `c_str_literals`'s stabilization has been delayed to 1.77 (rust-lang#119528).
…site, and used to immediately throw away the rest of the value. Let's use `Result` to statically signal that this is happening
Otherwise the specialization graph fails to pick it up, even though other code assumes that all impl blocks have an entry in the specialization graph.
…als, r=Nilstrieb Set `c_str_literals` stabilization version back to `CURRENT_RUSTC_VERSION` `c_str_literals`'s stabilization has been delayed to 1.77 (rust-lang#119528).
Convert `effects` description to doc comment So that it is visible here: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_feature/unstable/struct.Features.html#structfield.effects r? `@fee1-dead`
…mpiler-errors Register even erroneous impls Otherwise the specialization graph fails to pick it up, even though other code assumes that all impl blocks have an entry in the specialization graph. also includes an unrelated cleanup of the specialization graph query fixes rust-lang#119827
rustbot
added
S-waiting-on-review
|
@bors r+ rollup=never p=4 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 2b1365b34f In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Merged
|
Finished benchmarking commit (bfd799f): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 666.917s -> 665.086s (-0.27%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
c_str_literalsstabilization version back toCURRENT_RUSTC_VERSION#119865 (Setc_str_literalsstabilization version back toCURRENT_RUSTC_VERSION)effectsdescription to doc comment #119866 (Converteffectsdescription to doc comment)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup