-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Add aarch64-apple-visionos and aarch64-apple-visionos-sim tier 3 targets #121419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
4f6f433
Support for visionOS
agg23 11ea14e
Update visionOS MachO tests to require LLVM 18
agg23 51777dc
Add missing visionOS target metadata
agg23 f32ad2b
Fixed VISIONOS_DEPLOYMENT_TARGET envar test
agg23 f7870a3
Fix test formatting
agg23 4f7ac51
Fixed incorrectly named sim target in platform-support.md
agg23 572d6cd
Added note about LLVM 18 requirement
agg23 52960d4
Fixed builds with modified libc
agg23 61fd74f
Fixed bad formatting
agg23 fb09ddb
Added madsmtm as second maintainer
agg23 72aeeaf
Updated comments
agg23 288a615
Added target metadata
agg23 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
compiler/rustc_target/src/spec/targets/aarch64_apple_visionos.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
use crate::spec::base::apple::{opts, visionos_llvm_target, Arch}; | ||
use crate::spec::{FramePointer, SanitizerSet, Target, TargetOptions}; | ||
|
||
pub fn target() -> Target { | ||
let arch = Arch::Arm64; | ||
let mut base = opts("visionos", arch); | ||
base.supported_sanitizers = SanitizerSet::ADDRESS | SanitizerSet::THREAD; | ||
|
||
Target { | ||
llvm_target: visionos_llvm_target(arch).into(), | ||
metadata: crate::spec::TargetMetadata { | ||
description: None, | ||
tier: None, | ||
host_tools: None, | ||
std: None, | ||
}, | ||
pointer_width: 64, | ||
data_layout: "e-m:o-i64:64-i128:128-n32:64-S128".into(), | ||
arch: arch.target_arch(), | ||
options: TargetOptions { | ||
features: "+neon,+fp-armv8,+apple-a16".into(), | ||
max_atomic_width: Some(128), | ||
frame_pointer: FramePointer::NonLeaf, | ||
..base | ||
}, | ||
} | ||
} |
27 changes: 27 additions & 0 deletions
27
compiler/rustc_target/src/spec/targets/aarch64_apple_visionos_sim.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
use crate::spec::base::apple::{opts, visionos_sim_llvm_target, Arch}; | ||
use crate::spec::{FramePointer, SanitizerSet, Target, TargetOptions}; | ||
|
||
pub fn target() -> Target { | ||
let arch = Arch::Arm64_sim; | ||
let mut base = opts("visionos", arch); | ||
base.supported_sanitizers = SanitizerSet::ADDRESS | SanitizerSet::THREAD; | ||
|
||
Target { | ||
llvm_target: visionos_sim_llvm_target(arch).into(), | ||
metadata: crate::spec::TargetMetadata { | ||
description: None, | ||
tier: None, | ||
host_tools: None, | ||
std: None, | ||
}, | ||
pointer_width: 64, | ||
data_layout: "e-m:o-i64:64-i128:128-n32:64-S128".into(), | ||
arch: arch.target_arch(), | ||
options: TargetOptions { | ||
features: "+neon,+fp-armv8,+apple-a16".into(), | ||
max_atomic_width: Some(128), | ||
frame_pointer: FramePointer::NonLeaf, | ||
..base | ||
}, | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.