-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Handle str literals written with '
lexed as lifetime
#122217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
982918f
Handle str literals written with `'` lexed as lifetime
estebank 4a10b01
Use shorter span for existing `'` -> `"` structured suggestion
estebank 999a0dc
review comment: `str` -> string in messages
estebank 6f388ef
Extend test to trigger on 2015, 2018 and 2021 editions
estebank ea1883d
Silence redundant error on char literal that was meant to be a string…
estebank f4d30b1
fix rustdoc test
estebank File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
estebank marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,4 +1,8 @@ | ||||||
//@ run-rustfix | ||||||
//@ revisions: rust2015 rust2018 rust2021 | ||||||
//@[rust2018] edition:2018 | ||||||
//@[rust2021] edition:2021 | ||||||
fn main() { | ||||||
println!('hello world'); //~ ERROR unterminated character literal | ||||||
println!('hello world'); | ||||||
//[rust2015,rust2018,rust2021]~^ ERROR unterminated character literal | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could be simplified to
Suggested change
but not blocking. |
||||||
//[rust2021]~^^ ERROR prefix `world` is unknown | ||||||
} |
4 changes: 2 additions & 2 deletions
4
...exer/lex-bad-str-literal-as-char-3.stderr → ...bad-str-literal-as-char-3.rust2015.stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
tests/ui/lexer/lex-bad-str-literal-as-char-3.rust2018.stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
error[E0762]: unterminated character literal | ||
--> $DIR/lex-bad-str-literal-as-char-3.rs:5:26 | ||
| | ||
LL | println!('hello world'); | ||
| ^^^ | ||
| | ||
help: if you meant to write a string literal, use double quotes | ||
| | ||
LL | println!("hello world"); | ||
| ~ ~ | ||
|
||
error: aborting due to 1 previous error | ||
|
||
For more information about this error, try `rustc --explain E0762`. |
26 changes: 26 additions & 0 deletions
26
tests/ui/lexer/lex-bad-str-literal-as-char-3.rust2021.stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
error: prefix `world` is unknown | ||
--> $DIR/lex-bad-str-literal-as-char-3.rs:5:21 | ||
| | ||
LL | println!('hello world'); | ||
| ^^^^^ unknown prefix | ||
| | ||
= note: prefixed identifiers and literals are reserved since Rust 2021 | ||
help: if you meant to write a string literal, use double quotes | ||
| | ||
LL | println!("hello world"); | ||
| ~ ~ | ||
|
||
error[E0762]: unterminated character literal | ||
--> $DIR/lex-bad-str-literal-as-char-3.rs:5:26 | ||
| | ||
LL | println!('hello world'); | ||
| ^^^ | ||
| | ||
help: if you meant to write a string literal, use double quotes | ||
| | ||
LL | println!("hello world"); | ||
| ~ ~ | ||
|
||
error: aborting due to 2 previous errors | ||
|
||
For more information about this error, try `rustc --explain E0762`. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.