Rollup of 3 pull requests #123335
Closed
Rollup of 3 pull requests #123335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy paste error strike again..
truncate down to 32 (31 + 1) for solaris/illumos.
…ons, r=compiler-errors Fixup parsing of `rustc_never_type_options` attribute rust-lang#122843 had a copy paste error, which I did not caught when testing. r? ```@compiler-errors```
…ix, r=workingjubilee std::thread: set_name change for solaris/illumos. truncate down to 32 (31 + 1) for solaris/illumos.
…compiler-errors Update `ParamEnv` docs There is now a wealth of information in the dev guide about `ParamEnv` so we should explicitly link to it from the doc comments. I also added a caution against using `ParamEnv` and removed the comment about it being "suitable for type checking" as you should practically never use `ParamEnv::empty` for type checking r? `@compiler-errors`
rustbot
added
O-unix
|
@bors rollup=never p=3 r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 1, 2024
…kingjubilee Rollup of 3 pull requests Successful merges: - rust-lang#123320 (Fixup parsing of `rustc_never_type_options` attribute) - rust-lang#123323 (std::thread: set_name change for solaris/illumos.) - rust-lang#123327 (Update `ParamEnv` docs) r? `@ghost` `@rustbot` modify labels: rollup
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
oh lol. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
rustc_never_type_optionsattribute #123320 (Fixup parsing ofrustc_never_type_optionsattribute)ParamEnvdocs #123327 (UpdateParamEnvdocs)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup