-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Shrink backtrace generation in std #123964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
Shrink backtrace generation in std r? `@Mark-Simulacrum` (for perf)
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
previous attempt: #122462 |
Finished benchmarking commit (6bb7798): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 679.002s -> 676.764s (-0.33%) |
Thanks, hadn't seen that. Doesn't look like this had particularly good results on our overall binary sizes (https://perf.rust-lang.org/compare.html?start=5dcb678ad8dc23a518f9ddf907e6a08de923d05e&end=6bb779889bb749b512d00022777e298c9fda7fb7&stat=size%3Alinked_artifact&tab=artifact-size) though so going to close this. |
r? @Mark-Simulacrum (for perf)