rustdoc: web: don't reset the search bar #12439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors
added a commit
that referenced
this pull request
Feb 22, 2014
rustdoc: web: don't reset the search bar
| // Synchronize search bar with query string state and | ||
| // perform the search, but don't empty the bar if there's | ||
| // nothing there. | ||
| if params.search !== undefined { |
There was a problem hiding this comment.
Sadly I don't think JS has quite adopted rust syntax just yet :(
There was a problem hiding this comment.
ah crap
On Sat, Feb 22, 2014 at 3:24 PM, Alex Crichton [email protected]:
In src/librustdoc/html/static/main.js:
@@ -574,8 +579,12 @@
// When browsing forward to search results the previous search will be repeated,
// so the currentResults are cleared to ensure the search is successful.
currentResults = null;
// Synchronize search bar with query string state and perform the search.$('.search-input').val(params.search);// Synchronize search bar with query string state and// perform the search, but don't empty the bar if there's// nothing there.if params.search !== undefined {Sadly I don't think JS has quite adopted rust syntax just yet :(
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/12439/files#r9972844
.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
fix(completion): `super::` completion at crate root and module depth aware - should close rust-lang#12439 - Suggest super according to the depth in tree
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 18, 2024
fix ice reporting in lintcheck Fixes rust-lang/rust-clippy#12185 This PR fixes the lack of reported ICEs within lintcheck by modifying the way in which data is collected from each crate being linted. Instead of lintcheck only reading `stdout` for warnings, it now also reads `stderr` for any potential ICE (although admittedly, it is not the cleanest method of doing so). If it is detected, it parses the ICE into its message and backtrace separately, and then adds them to the list of outputs via clippy. Once all outputs are collected, the formatter then proceeds to generate the file as normal. Note that this PR also has a couple of side effects: - When clippy fails to process a package, but said failure is not an ICE, the `stderr` will be sent to the console; - Instead of `ClippyWarning` being the primary struct for everything reported, there is now `ClippyCheckOutput`, an enum which splits the outputs into warnings and ICEs. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustdoc: web: don't reset the search bar