Use super_fold in RegionsToStatic visitor
#124808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler-errors
commented
May 6, 2024
| @@ -2583,7 +2583,7 @@ impl<'tcx> SelectionContext<'_, 'tcx> { | |||
| self.infcx | |||
| .at(&obligation.cause, obligation.param_env) | |||
| .eq( | |||
| DefineOpaqueTypes::No, | |||
| DefineOpaqueTypes::Yes, | |||
compiler-errors
commented
May 6, 2024
| @@ -0,0 +1,8 @@ | |||
| //@ compile-flags: -Znext-solver=coherence | |||
There was a problem hiding this comment.
This ICEs on -Znext-solver, could add a separate revision I guess.
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 6, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#124520 (Document that `create_dir_all` calls `mkdir`/`CreateDirW` multiple times) - rust-lang#124724 (Prefer lower vtable candidates in select in new solver) - rust-lang#124771 (Don't consider candidates with no failing where clauses when refining obligation causes in new solver) - rust-lang#124808 (Use `super_fold` in `RegionsToStatic` visitor) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 6, 2024
Rollup merge of rust-lang#124808 - compiler-errors:super, r=lcnr Use `super_fold` in `RegionsToStatic` visitor so as to avoid an infinite stack cycle fixes rust-lang#124805 r? lcnr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so as to avoid an infinite stack cycle
fixes #124805
r? lcnr