-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Adjust 64-bit ARM data layouts for LLVM update #124813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LLVM has updated data layouts to specify `Fn32` on 64-bit ARM to avoid C++ accidentally underaligning functions when trying to comply with member function ABIs. This should only affect Rust in cases where we had a similar bug (I don't believe we have one), but our data layout must match to generate code. As a compatibility adaptatation, if LLVM is not version 19 yet, `Fn32` gets voided from the data layout. See llvm/llvm-project#90415
These commits modify compiler targets. |
This looks basically fine to me, but I also only peripherally understand this so... @rustbot r? compiler |
@bors r+ |
Adjust 64-bit ARM data layouts for LLVM update LLVM has updated data layouts to specify `Fn32` on 64-bit ARM to avoid C++ accidentally underaligning functions when trying to comply with member function ABIs. This should only affect Rust in cases where we had a similar bug (I don't believe we have one), but our data layout must match to generate code. As a compatibility adaptatation, if LLVM is not version 19 yet, `Fn32` gets voided from the data layout. See llvm/llvm-project#90415 `@rustbot` label: +llvm-main cc `@krasimirgg` r? `@durin42`
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
@bors retry remote-test-client failure |
☀️ Test successful - checks-actions |
Finished benchmarking commit (d71b3f4): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 673.849s -> 676.36s (0.37%) |
Rust data layout for aarch64 updated in 1.80.0 release following LLVM data layout update (see: rust-lang/rust#124813). So conditionally update data layout for aarch64 target build as well. Signed-off-by: Sumit Garg <[email protected]>
Rust data layout for aarch64 updated in 1.80.0 release following LLVM data layout update (see: rust-lang/rust#124813). So conditionally update data layout for aarch64 target build as well. Signed-off-by: Sumit Garg <[email protected]>
Rust data layout for aarch64 updated in 1.80.0 release following LLVM data layout update (see: rust-lang/rust#124813). So conditionally update data layout for aarch64 target build as well. Signed-off-by: Sumit Garg <[email protected]> Signed-off-by: Benoît Mauduit <[email protected]>
LLVM has updated data layouts to specify
Fn32
on 64-bit ARM to avoid C++ accidentally underaligning functions when trying to comply with member function ABIs.This should only affect Rust in cases where we had a similar bug (I don't believe we have one), but our data layout must match to generate code.
As a compatibility adaptatation, if LLVM is not version 19 yet,
Fn32
gets voided from the data layout.See llvm/llvm-project#90415
@rustbot label: +llvm-main
cc @krasimirgg
r? @durin42