-
Notifications
You must be signed in to change notification settings - Fork 13.4k
android: use posix_memalign for aligned allocations #125244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...wait, I'm an idiot, 19 is higher than 16. |
Yeah, that's correct. @bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (cf2baaa): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 3.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 669.005s -> 671.867s (0.43%) |
Our target page says
According to this, the minimum API level of the current LTS NDK is 21. According to this, posix_memalign exists since API level 16. So I think we should be able to use it here?