rustc: Streamline error messages for i18n, using plural whenever possible
#12678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stylistically, This seems like a nice improvement though, thanks! |
| out_type_size, | ||
| pluralize(out_type_size))); | ||
| format!("transmute called on types with different sizes: \ | ||
| {} ({, plural, =1{# bit} other{# bits}}) to \ |
There was a problem hiding this comment.
Not a point against this change; but is it ever possible to have 1 bit type in Rust?
|
@alexcrichton Indeed. I wanted to avoid changing them in this PR though since larger stylistic changes are required for consistency, but I have no hard feeling about that. I'll try to sort them out then. |
bors
added a commit
that referenced
this pull request
Mar 4, 2014
While we are not yet ready for compiler i18n, this also keeps the error handling code clean. The set of altered error messages was obtained by grepping for `"s"` and `(s)`, so there might be some missing messages.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
fix: Trigger flyimport completions in item lists again Fixes rust-lang/rust-analyzer#12656
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 18, 2024
Bump nightly version -> 2024-04-05 r? `@ghost` changelog: none This should unblock CI without doing a full sync. Proper sync on Thursday.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we are not yet ready for compiler i18n, this also keeps the error handling code clean. The set of altered error messages was obtained by grepping for
"s"and(s), so there might be some missing messages.