Didyoumean #12979
Didyoumean #12979
Conversation
…n't found, it scans for the same symbol ident and shows their full path. much cleanup needed..
|
A few things which should be addressed before review:
|
|
Usability experts advice to "not blame the user". Do you see a way to formulate the messages without using "you"? |
|
perhaps.. |
|
Closing due to inactivity, but feel free to reopen with comments addressed! |
|
It might be better if i can find a less invasive way of doing this - currently I changed a structure to pass an intermediate, if I can do it without that I can actively maintain this feature and submit it when you're happy with it. i need to find how to get 'the current crate' for the module being resolved. I did find it useful... and i'm sure all the newcomers bewildered by the module system will benefit... its one of many approaches to help adressing the one thing that''s keeping me in C++, the powerful navigation available in IDEs |
Convert the ICE reported in rust-lang#12979 into a false negative. We prefer a false negative to a ICE (because the ICE could still affect the user even when not activating the lint).
This PR just makes sure that we exit the function before getting an ICE and adds a regression test. Related to rust-lang#12979. We would need to keep researching the issue, but as the ICEing code isn't that complicated, getting a hotfix into nightly is urgent. changelog:[`borrow_interior_mutable_const`] Fix ICE rust-lang#12979
additonal note to error messages when a symbol isn't found - if the symbol exists in other paths, up to 5 suggestions are given, showing their full global path, prioritized by the number of segments matched.
Especially intended to educate&assist newcommers with the module system , which behaves in an unexpected way to users of most other languages.
(added "fn show_suggestions_from_other_scopes(), "find_suggestions_from_other_scopes()" which dont affect the compiler state.)