Remove RefCell::{with, with_mut} #13052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are superfluous now that we have fixed rvalue lifetimes and Deref.
|
@alexcrichton Updated with some marker type cleanup. |
bors
added a commit
that referenced
this pull request
Mar 22, 2014
These are superfluous now that we have fixed rvalue lifetimes and Deref. I'd also like to kill off `get` and `set`, but that'll be a large change so I want to make sure that we actually want to do that first.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 11, 2024
…Alexendoo Lintcheck: Add `--warn-all` and make it the CI default This PR adds a new `--warn-all` flag to lintcheck. This is intended for our CI, as it currently doesn't detect changes of `nursery` and `restriction` lints. I only made it the default for the CI, as `restriction` lints tend to generate A LOT of lint triggers. Looking at you [`clippy::implicit_return`](https://rust-lang.github.io/rust-clippy/master/index.html#/clippy::implicit_return) That's it. Should hopefully be easy to review. Also, a bit thanks again to `@Alexendoo` for adding this to our CI ❤️ --- r? `@Alexendoo` changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are superfluous now that we have fixed rvalue lifetimes and Deref.
I'd also like to kill off
getandset, but that'll be a large change so I want to make sure that we actually want to do that first.