This commit cleans up a few test warnings #13096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1282,10 +1282,10 @@ mod test { | |||
| } | |||
|
|
|||
| iotest!(fn binary_file() { | |||
| use rand::{rng, Rng}; | |||
| use rand::{Rng, StdRng}; | |||
There was a problem hiding this comment.
Can you make this task_rng? (Creating a StdRng is needlessly expensive.)
There was a problem hiding this comment.
That makes sense. However, I'll try to do better. I'll create a new pull request that hunts through test cases for StdRng::new() and replaces it with task_rng(). NVM I was confused.
bors
added a commit
that referenced
this pull request
Mar 23, 2014
JohnTitor
pushed a commit
to JohnTitor/rust
that referenced
this pull request
Aug 30, 2022
…=jonas-schievink fix: Allow leading `|` in more pattern positions fixes rust-lang/rust-analyzer#12894, fixes rust-lang/rust-analyzer#13094 Oddly, the leading `|` token does not end up inside the `OR_PAT` node, since `pattern_top_r` consumes it first. This is a preexisting issue in match arms though, so I didn't fix it here.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 25, 2024
fix [`excessive_precision`] suggestions on floats written in scientific notation fixes rust-lang#12954 changelog: fix [`excessive_precision`] suggestions on float literal written in scientific notation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.