-
Notifications
You must be signed in to change notification settings - Fork 13.3k
E0793: Clarify that it applies to unions as well #131472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -1,4 +1,4 @@ | ||||||||||||||||||||||
An unaligned references to a field of a [packed] struct got created. | ||||||||||||||||||||||
An unaligned reference to a field of a [packed] `struct` or `union` was created. | ||||||||||||||||||||||
|
||||||||||||||||||||||
Erroneous code example: | ||||||||||||||||||||||
|
||||||||||||||||||||||
|
@@ -45,9 +45,36 @@ unsafe { | |||||||||||||||||||||
// For formatting, we can create a copy to avoid the direct reference. | ||||||||||||||||||||||
let copy = foo.field1; | ||||||||||||||||||||||
println!("{}", copy); | ||||||||||||||||||||||
|
||||||||||||||||||||||
// Creating a copy can be written in a single line with curly braces. | ||||||||||||||||||||||
// (This is equivalent to the two lines above.) | ||||||||||||||||||||||
println!("{}", { foo.field1 }); | ||||||||||||||||||||||
|
||||||||||||||||||||||
// A reference to a field that will always be sufficiently aligned is safe: | ||||||||||||||||||||||
println!("{}", foo.field2); | ||||||||||||||||||||||
} | ||||||||||||||||||||||
``` | ||||||||||||||||||||||
|
||||||||||||||||||||||
### Unions | ||||||||||||||||||||||
|
||||||||||||||||||||||
Even though creating a reference to a `union` field is `unsafe`, this error | ||||||||||||||||||||||
will still be triggered when referencing a field that is not sufficiently | ||||||||||||||||||||||
aligned. `addr_of!` and raw pointers should be used the same way as is done | ||||||||||||||||||||||
for `struct` fields. | ||||||||||||||||||||||
|
||||||||||||||||||||||
```compile_fail,E0793 | ||||||||||||||||||||||
#[repr(packed)] | ||||||||||||||||||||||
pub union Foo { | ||||||||||||||||||||||
field1: u64, | ||||||||||||||||||||||
field2: u8, | ||||||||||||||||||||||
} | ||||||||||||||||||||||
|
||||||||||||||||||||||
unsafe { | ||||||||||||||||||||||
let foo = Foo { field1: 0 }; | ||||||||||||||||||||||
// Accessing the field directly is fine. | ||||||||||||||||||||||
let val = foo.field1; | ||||||||||||||||||||||
// A reference to a packed union field causes a error. | ||||||||||||||||||||||
let val = &foo.field1; // ERROR | ||||||||||||||||||||||
} | ||||||||||||||||||||||
Comment on lines
+74
to
+77
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||||
``` | ||||||||||||||||||||||
|
||||||||||||||||||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.