-
Notifications
You must be signed in to change notification settings - Fork 13.3k
query/plumbing: adjust comment to reality #132854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bors r+ rollup |
☀️ Test successful - checks-actions |
Finished benchmarking commit (3a258d1): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -2.7%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 785.591s -> 786.407s (0.10%) |
…-errors query/plumbing: adjust comment to reality The limit for the query key size got changed recently in rust-lang@f51ec11 but the comment was not updated. Though maybe it is time to intern `CanonicalTypeOpAscribeUserTypeGoal` rather than copying it everywhere? r? `@lcnr`
The limit for the query key size got changed recently in f51ec11 but the comment was not updated.
Though maybe it is time to intern
CanonicalTypeOpAscribeUserTypeGoal
rather than copying it everywhere?r? @lcnr