-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Run TLS destructors for wasm32-wasip1-threads #133472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
ec5f41a
Run TLS destructors for wasm32-wasip1-threads
surban 4fe15b0
Use UNIX thread_local implementation for WASI.
surban e4092bd
Fix compilation for wasm32-wasip1 (without threads).
surban 4f16640
Add libc funcitons only for wasm32-wasip1-threads.
surban File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
//! wasm32-wasip1 has pthreads support. | ||
|
||
use crate::cell::Cell; | ||
use crate::sync::atomic::{AtomicBool, Ordering}; | ||
use crate::sys::thread_local::destructors; | ||
use crate::{ffi, ptr}; | ||
|
||
// Add a few symbols not in upstream `libc` just yet. | ||
mod libc { | ||
pub use libc::*; | ||
|
||
use crate::ffi; | ||
|
||
#[allow(non_camel_case_types)] | ||
pub type pthread_key_t = ffi::c_uint; | ||
|
||
extern "C" { | ||
pub fn pthread_key_create( | ||
key: *mut pthread_key_t, | ||
destructor: unsafe extern "C" fn(*mut ffi::c_void), | ||
) -> ffi::c_int; | ||
|
||
pub fn pthread_setspecific(key: pthread_key_t, value: *const ffi::c_void) -> ffi::c_int; | ||
} | ||
} | ||
|
||
pub fn enable() { | ||
enable_main(); | ||
enable_thread(); | ||
} | ||
|
||
fn enable_main() { | ||
static REGISTERED: AtomicBool = AtomicBool::new(false); | ||
|
||
if !REGISTERED.swap(true, Ordering::AcqRel) { | ||
unsafe { | ||
assert_eq!(libc::atexit(run_main_dtors), 0); | ||
} | ||
} | ||
|
||
extern "C" fn run_main_dtors() { | ||
unsafe { | ||
destructors::run(); | ||
crate::rt::thread_cleanup(); | ||
} | ||
} | ||
} | ||
|
||
fn enable_thread() { | ||
#[thread_local] | ||
static REGISTERED: Cell<bool> = Cell::new(false); | ||
|
||
if !REGISTERED.replace(true) { | ||
unsafe { | ||
let mut key: libc::pthread_key_t = 0; | ||
assert_eq!(libc::pthread_key_create(&mut key, run_thread_dtors), 0); | ||
surban marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
// We must set the value to a non-NULL pointer value so that | ||
// the destructor is run on thread exit. The pointer is only | ||
// passed to run_dtors and never dereferenced. | ||
assert_eq!(libc::pthread_setspecific(key, ptr::without_provenance(1)), 0); | ||
} | ||
} | ||
|
||
extern "C" fn run_thread_dtors(_: *mut ffi::c_void) { | ||
unsafe { | ||
destructors::run(); | ||
crate::rt::thread_cleanup(); | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.