Skip to content

CI: update linux 4c from ubuntu 20 to ubuntu 22 #134132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

marcoieni
Copy link
Member

@marcoieni marcoieni commented Dec 10, 2024

Related to rust-lang/infra-team#182

The PR checks sould be enough to understand if the ubuntu 22 runner will work.
Imo we can merge this and migrate large runners next.

@rustbot
Copy link
Collaborator

rustbot commented Dec 10, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 10, 2024
@marcoieni marcoieni marked this pull request as ready for review December 10, 2024 16:03
@Kobzol
Copy link
Contributor

Kobzol commented Dec 16, 2024

The corresponding Linux runners use their own Docker images that select their glibc baselines, so this hopefully shouldn't cause disruptions. Still, for an abundance of caution, marking as rollup=never.

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Dec 16, 2024

📌 Commit 89ad1ac has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2024
@bors
Copy link
Collaborator

bors commented Dec 17, 2024

⌛ Testing commit 89ad1ac with merge 52f4785...

@bors
Copy link
Collaborator

bors commented Dec 17, 2024

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 52f4785 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 17, 2024
@bors bors merged commit 52f4785 into rust-lang:master Dec 17, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 17, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (52f4785): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.9%, secondary 2.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.7% [2.7%, 2.7%] 1
Improvements ✅
(primary)
-2.9% [-4.2%, -1.6%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.9% [-4.2%, -1.6%] 2

Cycles

Results (secondary -7.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-7.1% [-8.5%, -5.5%] 3
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 771.372s -> 773.739s (0.31%)
Artifact size: 333.00 MiB -> 332.93 MiB (-0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants