-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Move mutability from ty_vec and ty_trait to their respective stores. #13424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@nikomatsakis you may be interested in looking at this PR. |
I'm not totally sold on the generic |
(And there's a few places where there's some mildly annoying duplication due to it. :( ) |
This looks pretty nice! btw, thanks for factoring things into their own commits, that was helpful. |
r+ from me once nits are fixed |
@huonw The pretty printer was causing bloat due to 4 (if I'm not mistaken) implementations in rustc. |
Failure looks legit. |
Cleans up some remnants of the old mutability system and only allows vector/trait mutability in `VstoreSlice` (`&mut [T]`) and `RegionTraitStore` (`&mut Trait`).
Cleans up some remnants of the old mutability system and only allows vector/trait mutability in
VstoreSlice
(&mut [T]
) andRegionTraitStore
(&mut Trait
).