Skip to content

next-solver: disable unnecessary hack #134574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Dec 20, 2024

the new solver never constrains inference variables to normalizeable aliases, so this is no longer necessary.

@rustbot
Copy link
Collaborator

rustbot commented Dec 20, 2024

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 20, 2024
@compiler-errors
Copy link
Member

army

@lcnr
Copy link
Contributor Author

lcnr commented Dec 20, 2024

r? @compiler-errors

@bors r=compiler-errors rollup

@bors
Copy link
Collaborator

bors commented Dec 20, 2024

📌 Commit 6bc1fe1 has been approved by compiler-errors

It is now in the queue for this repository.

@rustbot rustbot assigned compiler-errors and unassigned BoxyUwU Dec 20, 2024
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2024
@lcnr lcnr added the WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) label Dec 20, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2024
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#134556 ([tiny] fix missing ns units in bootstrap's benchmark rendering)
 - rust-lang#134560 (mri: add track_caller to thread spawning methods for better backtraces)
 - rust-lang#134561 (Reduce the amount of explicit FatalError.raise())
 - rust-lang#134562 (tests/codegen/asm: Remove uses of rustc_attrs and lang_items features by using minicore)
 - rust-lang#134567 (Remove some dead code around import library generation)
 - rust-lang#134570 (remove reference to dangling from slice::Iter)
 - rust-lang#134573 (unimplement `PointerLike` for trait objects)
 - rust-lang#134574 (next-solver: disable unnecessary hack)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 10a7405 into rust-lang:master Dec 20, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2024
Rollup merge of rust-lang#134574 - lcnr:opaque-ty-hack-yeet, r=compiler-errors

next-solver: disable unnecessary hack

the new solver never constrains inference variables to normalizeable aliases, so this is no longer necessary.
@rustbot rustbot added this to the 1.85.0 milestone Dec 20, 2024
@lcnr lcnr deleted the opaque-ty-hack-yeet branch December 23, 2024 08:54
@lcnr lcnr restored the opaque-ty-hack-yeet branch January 30, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants