-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add support for excluding tests via config.toml #135538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add support for excluding tests via config.toml #135538
Conversation
rustbot has assigned @Mark-Simulacrum. Use |
This PR modifies If appropriate, please update This PR modifies If appropriate, please update |
This comment has been minimized.
This comment has been minimized.
0338a33
to
13123c6
Compare
This comment has been minimized.
This comment has been minimized.
PathSet::Set(set) => set.iter().any(|p| Self::check(p, needle, module)), | ||
PathSet::Suite(suite) => Self::check(suite, needle, module), | ||
PathSet::Set(set) => { | ||
set.iter().any(|p| p.path == needle && Self::check(p, needle, module)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels suspicious. I think we already have a mechanism for skipping things (--exclude on the CLI) so I'd expect that any config.toml mechanism matches the behavior of that. Why do you need to change anything except plumbing through the new config.toml field to match the behavior of --exclude
?
@rustbot author |
☔ The latest upstream changes (presumably #137001) made this pull request unmergeable. Please resolve the merge conflicts. |
There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged. You can start a rebase with the following commands:
The following commits are merge commits: |
The job Click to see the possible cause of the failure (guessed by this bot)
|
@Aditya-PS-05 any updates on this? thanks |
closes #35678