Skip to content

bootstrap: still require COMPILETEST_FORCE_STAGE0 for ./x test rustdoc-js --stage 0 #135605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Jan 17, 2025

This PR reverts #135375, because through some more testing I found out ./x test rustdoc-js --stage 0 does not in fact build rustdoc, and all the tests fail. This can't be intended behavior, so at least require COMPILETEST_FORCE_STAGE0 to make it less likely to run rustdoc-js --stage 0 by accident.

The problem that --stage 0 is not working at all for this rustdoc-js test suite is tracked over at #135603.

cc @lolbinarycat

r? bootstrap

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jan 17, 2025
@jieyouxu jieyouxu changed the title compiletest: still require COMPILETEST_FORCE_STAGE0 for ./x test rustdoc-js --stage 0 bootstrap: still require COMPILETEST_FORCE_STAGE0 for ./x test rustdoc-js --stage 0 Jan 17, 2025
@clubby789
Copy link
Contributor

@bors r+ p=1

(contributor roadblock)

@bors
Copy link
Collaborator

bors commented Jan 17, 2025

📌 Commit 097cb1a has been approved by clubby789

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 17, 2025
@jieyouxu
Copy link
Member Author

@bors rollup (can be rolled up)

@bors
Copy link
Collaborator

bors commented Jan 17, 2025

⌛ Testing commit 097cb1a with merge bb3fa4b...

@bors
Copy link
Collaborator

bors commented Jan 17, 2025

☀️ Test successful - checks-actions
Approved by: clubby789
Pushing bb3fa4b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 17, 2025
@bors bors merged commit bb3fa4b into rust-lang:master Jan 17, 2025
7 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 17, 2025
@jieyouxu jieyouxu deleted the temp-require-force-rustdoc-js branch January 17, 2025 05:17
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bb3fa4b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.4%, secondary 0.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.8% [1.8%, 1.8%] 1
Regressions ❌
(secondary)
2.3% [2.3%, 2.3%] 1
Improvements ✅
(primary)
-1.9% [-2.5%, -1.0%] 6
Improvements ✅
(secondary)
-0.7% [-0.7%, -0.7%] 1
All ❌✅ (primary) -1.4% [-2.5%, 1.8%] 7

Cycles

Results (primary 0.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.9% [0.9%, 0.9%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.9% [0.9%, 0.9%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 765.257s -> 763.565s (-0.22%)
Artifact size: 326.05 MiB -> 326.08 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants