-
Notifications
You must be signed in to change notification settings - Fork 13.3k
bootstrap: still require COMPILETEST_FORCE_STAGE0
for ./x test rustdoc-js --stage 0
#135605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
COMPILETEST_FORCE_STAGE0
for ./x test rustdoc-js --stage 0
COMPILETEST_FORCE_STAGE0
for ./x test rustdoc-js --stage 0
@bors r+ p=1 (contributor roadblock) |
@bors rollup (can be rolled up) |
☀️ Test successful - checks-actions |
Finished benchmarking commit (bb3fa4b): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -1.4%, secondary 0.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 0.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 765.257s -> 763.565s (-0.22%) |
This PR reverts #135375, because through some more testing I found out
./x test rustdoc-js --stage 0
does not in fact build rustdoc, and all the tests fail. This can't be intended behavior, so at least requireCOMPILETEST_FORCE_STAGE0
to make it less likely to runrustdoc-js --stage 0
by accident.The problem that
--stage 0
is not working at all for this rustdoc-js test suite is tracked over at #135603.cc @lolbinarycat
r? bootstrap