Skip to content

Rustc dev guide subtree update #136254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Jan 30, 2025
Merged

Rustc dev guide subtree update #136254

merged 27 commits into from
Jan 30, 2025

Conversation

BoxyUwU
Copy link
Member

@BoxyUwU BoxyUwU commented Jan 29, 2025

r? @Kobzol

Kobzol and others added 27 commits January 21, 2025 17:00
@Kobzol
Add @bors rollup=never to rustc-push PR body
5be02d6
@jieyouxu
Merge pull request rust-lang#2217 from Kobzol/bors-rollup-never
0974081
@Kobzol
Revert "Add @bors rollup=never to rustc-push PR body"
353d916
@ada4a
fix(solve/significant-changes): typo
17a14b6
@jieyouxu
Merge pull request rust-lang#2220 from rust-lang/revert-2217-bors-rol…
93d73d3 
…lup-never
@JohnTitor
Merge pull request rust-lang#2221 from ada4a/patch-1
bda5664
@marxin
CI: use key-restore for cache GH action
1392e07 
It seems one can't overwrite a cache entry:
```
Failed to save: Unable to reserve cache with key linkcheck--0.8.1, another job may be creating this cache. More details: Cache already exists. Scope: refs/heads/master, Key: linkcheck--0.8.1, Version: 33f8fd511bed9c91c40778bc5c27cb58425caa894ab50f9c5705d83cb78660e0
Warning: Cache save failed.
```

A proper solution is to use `restore-keys`:
https://github.com/actions/cache/blob/main/tips-and-workarounds.md#update-a-cache
@ehuss
Update boring lines to sync with rustdoc
40e051f
@fmease
Remove accidental leading empty line in code block
20818c4
@fmease
Merge pull request rust-lang#2224 from ehuss/rustdoc-boring
c8ed8d4 
Update boring lines to sync with rustdoc
@ehuss
Correct information on dylib compression
5210a8d 
Compression of dylibs was removed in rust-lang#113695 (and decompression removed in rust-lang#132402).
@tshepang
Merge pull request rust-lang#2225 from ehuss/patch-3
f6bd61a 
Correct information on dylib compression
@camelid
Merge pull request rust-lang#2223 from marxin/CI-cache-restore-key
885641b 
CI: use key-restore for cache GH action
@Kobzol
Fix rustc-pull CI's bash commands
2412289
@jieyouxu
Merge pull request rust-lang#2226 from Kobzol/rustc-pull-ci-bash
3d4b24a 
Fix rustc-pull CI's bash commands
@Joren-vanGoethem
Update about-this-guide.md
d63796f
@BoxyUwU
Preparing for merge from rustc
62102ee
@BoxyUwU
Merge from rustc
815c5d4
@notriddle
Add some extra pointers for rustdoc frontend devs
5861aa2
@yegeunyang
Add "Writing tests" section
941ab8c
@yegeunyang
Add link to declare_lint! macro
0127e64
@jieyouxu
Merge pull request rust-lang#2229 from notriddle/typescript
8520031 
Add some extra pointers for rustdoc frontend devs
@jieyouxu
Merge pull request rust-lang#2232 from yegeunyang/rust-lang#2114
d8cca31 
Add a link to declare_lint! macro doc in diagnostics.md
@yegeunyang
Touch up a sentence
4260e3a
@jieyouxu
Merge pull request rust-lang#2231 from yegeunyang/rust-lang#2069
7fa9822
@jieyouxu
Merge pull request rust-lang#2227 from Joren-vanGoethem/master
bec4359
@BoxyUwU
Rustc pull
0b48908
@rustbot
Copy link
Collaborator

rustbot commented Jan 29, 2025

Could not assign reviewer from: Kobzol.
User(s) Kobzol are either the PR author, already assigned, or on vacation. Please use r? to specify someone else to assign.

@rustbot
Copy link
Collaborator

rustbot commented Jan 29, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 29, 2025

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol

@BoxyUwU BoxyUwU assigned Kobzol and unassigned fee1-dead Jan 29, 2025
@Kobzol
Copy link
Contributor

Kobzol commented Jan 29, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 29, 2025

📌 Commit 0b48908 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2025
@Zalathar Zalathar mentioned this pull request Jan 30, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 30, 2025
@bors
Auto merge of rust-lang#136272 - Zalathar:rollup-6s577l5, r=Zalathar
e6f12c8 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#135847 (optimize slice::ptr_rotate for small rotates)
 - rust-lang#136215 (btree/node.rs: remove incorrect comment from pop_internal_level docs)
 - rust-lang#136252 (spastorino back from vacations)
 - rust-lang#136254 (Rustc dev guide subtree update)
 - rust-lang#136259 (Cleanup docs for Allocator)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 48b3eca into rust-lang:master Jan 30, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 30, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 30, 2025
@rust-timer
Unrolled build for rust-lang#136254
ffb442e 
Rollup merge of rust-lang#136254 - BoxyUwU:rdg-push, r=Kobzol

Rustc dev guide subtree update

r? `@Kobzol`
@BoxyUwU BoxyUwU deleted the rdg-push branch February 11, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Kobzol Kobzol

Labels
A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.