shootout-fannkuch-redux rewrite #13633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for i in range(1, n) { | ||
| let perm = perm.as_mut_slice(); | ||
| let count = count.as_mut_slice(); | ||
| unsafe { |
There was a problem hiding this comment.
It would be a bit sad if we can only show off how fast rust is with the usage of unsafe code, can this be rewritten to use iterators to eliminate bounds checking?
|
@alexcrichton if you have an idea of how to do that, I'm interrested. |
| } else { | ||
| *count.unsafe_mut_ref(i) += 1; | ||
| break; | ||
| } |
There was a problem hiding this comment.
This should be able to get replaced with:
for (i, count_slot) in count.mut_iter().enumerate() {
...
}
Less bound checking and parallelisation. Brute speed improvement is about 15% faster.
|
@alexcrichton safe indice version amended. |
bors
added a commit
that referenced
this pull request
Apr 20, 2014
…r=alexcrichton Less bound checking and parallelisation. Brute speed improvement is about 15% faster. The unsafe block improve the brute speed by about 5%.
Manishearth
pushed a commit
to Manishearth/rust
that referenced
this pull request
Nov 23, 2022
…ykril feat: Allow viewing the full compiler diagnostic in a readonly textview  Also adds a VSCode only config that replaces the split diagnostic message with the first relevant part of the diagnostic output  This only affects diagnostics generated by primary spans and has no effect on other clients than VSCode. Fixes rust-lang/rust-analyzer#13574
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 7, 2024
…coap, r=Centri3 Add 'CoAP' to doc-valid-idents CoAP is a name of a network protocol common in embedded systems; one would talk in documentation about "a CoAP server" or "a CoAP client" without referring to a specific type. This PR fixes false positives that arise from that use. changelog: [`doc_markdown`]: Add CoAP to `doc-valid-idents`. As this review is identical in structure to rust-lang/rust-clippy#13460, I'm asking for a the same reviewer (if that works): r? `@Centri3`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Less bound checking and parallelisation. Brute speed improvement
is about 15% faster.
The unsafe block improve the brute speed by about 5%.